Tony Bark@pawb.social to Linux@lemmy.world · edit-213 days agoTorvalds blasts kernel dev for late 'garbage' RISC-V patcheswww.theregister.comexternal-linkmessage-square10linkfedilinkarrow-up17arrow-down11cross-posted to: linux@programming.dev
arrow-up16arrow-down1external-linkTorvalds blasts kernel dev for late 'garbage' RISC-V patcheswww.theregister.comTony Bark@pawb.social to Linux@lemmy.world · edit-213 days agomessage-square10linkfedilinkcross-posted to: linux@programming.dev
minus-squareVeryFrugal@sh.itjust.workslinkfedilinkEnglisharrow-up2·13 days ago Like this crazy and pointless make_u32_from_two_u16() ‘helper’. That thing makes the world actively a worse place to live. I love how enthusiastic he is about make_u32_from_two_u16()
minus-squaresquaresinger@lemmy.worldlinkfedilinkEnglisharrow-up1·12 days agoIt really is kinda hard to justify wrapping a << 16 | b in a function.
minus-squareMysteriousSophon21@lemmy.worldlinkfedilinkEnglisharrow-up2·7 days agoYep, these kind of wrapper functions actually hurt kernel readability and add unecessary call overhead - in critical kernel paths every instruction counts.
minus-squareTheTechnician27@lemmy.worldlinkfedilinkEnglisharrow-up1·edit-211 days agoEspecially given that one actually tells you where the values get placed.
I love how enthusiastic he is about
make_u32_from_two_u16()It really is kinda hard to justify wrapping
a << 16 | bin a function.Yep, these kind of wrapper functions actually hurt kernel readability and add unecessary call overhead - in critical kernel paths every instruction counts.
Especially given that one actually tells you where the values get placed.